Fix playlist toggle breaking when reloading page#196
Merged
Conversation
Owner
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #187
When Explo starts, cleanenv loads all .env values into OS process memory via os.Setenv. If a playlist schedule exists in .env at startup, it lives in both the file and process memory.
When you toggle a schedule off, handleSaveSchedule removes the key from .env but never calls os.Unsetenv, so the stale value stays in memory. On the next page load, handleGetConfig checks the file first then falls back to os.LookupEnv, finds the stale value, and marks it source: "env". The frontend sees "env" as externally controlled and locks the toggle, showing the ENV text and an error cursor. Restarting the container clears process memory which is why the bug doesn't survive restarts.
The fix:
Added os.Unsetenv / os.Setenv in handleSaveSchedule after updateEnvKeys writes to the disk, keeping OS process memory in sync with the file on each toggle.